Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps swift version to make swiftNIO build possible #12883

Closed
wants to merge 1 commit into from

Conversation

TobiasWienand
Copy link

Fixes issue #12882

@TobiasWienand TobiasWienand changed the title bug-fix/bumps swift version to make swiftNIO build possible bumps swift version to make swiftNIO build possible Dec 26, 2024
@DonggeLiu
Copy link
Contributor

Checking if this will have unexpected side effects on other swift projects

@DonggeLiu
Copy link
Contributor

/gcbrun trial_build.py swift

@thomasvl
Copy link
Member

@DonggeLiu what needs to happen for this to move forward?

The failure sorta looks like it was trying to enforce some branch naming requirements on incoming PRs which seems like an odd choice.

@DonggeLiu
Copy link
Contributor

Yep, that appears to block the trial build.
Let me try a different trick that I learnt from @jonathanmetzman .

@DonggeLiu
Copy link
Contributor

/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --sanitizer address memory undefined coverage --fuzzing-engine libfuzzer afl honggfuzz

@thomasvl
Copy link
Member

Looks like that still failed. Is it documented some place what the naming requirements are for PRs?

@jonathanmetzman
Copy link
Contributor

Looks like that still failed. Is it documented some place what the naming requirements are for PRs?

Sorry about that. It's not a requirement of PRs in general, just ones that need gcbrun tests.
Here's the pattern the name must match "^[\w][\w.-]{0,127}$" i.e. no "/"

thomasvl added a commit to thomasvl/oss-fuzz that referenced this pull request Jan 29, 2025
Fixes issue google#12882

This is google#12883, but on a differently
named branch to hopefully get it to pass CI.
@thomasvl
Copy link
Member

I've opened #12990 which should be the same changes, but on a differently named branch, hopefully that can pass CI and be landed.

@thomasvl
Copy link
Member

@jonathanmetzman @DonggeLiu fyi

@TobiasWienand TobiasWienand deleted the fix/swift-nio branch January 29, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants