-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumps swift version to make swiftNIO build possible #12883
Conversation
Checking if this will have unexpected side effects on other swift projects |
/gcbrun trial_build.py swift |
@DonggeLiu what needs to happen for this to move forward? The failure sorta looks like it was trying to enforce some branch naming requirements on incoming PRs which seems like an odd choice. |
Yep, that appears to block the trial build. |
/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --sanitizer address memory undefined coverage --fuzzing-engine libfuzzer afl honggfuzz |
Looks like that still failed. Is it documented some place what the naming requirements are for PRs? |
Sorry about that. It's not a requirement of PRs in general, just ones that need gcbrun tests. |
Fixes issue google#12882 This is google#12883, but on a differently named branch to hopefully get it to pass CI.
I've opened #12990 which should be the same changes, but on a differently named branch, hopefully that can pass CI and be landed. |
Fixes issue #12882