Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复tls输出乱码问题 #419

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion user/event/event_openssl.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func (se *SSLDataEvent) String() string {

func (se *SSLDataEvent) Clone() IEventStruct {
event := new(SSLDataEvent)
event.eventType = EventTypeModuleData //EventTypeEventProcessor
event.eventType = EventTypeEventProcessor //EventTypeModuleData //EventTypeEventProcessor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从你提的issue #415 看到,好像是已经正常打印reponse了。我需要验证一下bug是否存在。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯,好,这个我在测试后发现改了这个type后就能输出明文。你看下如果原来的是没问题的,那么应该是我的理解存在错误。哈哈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你理解的应该也没问题。

这里比较复杂,EventTypeEventProcessor 确实会对 gzip之类已编码的包进行二次解码,有很多需要组包的过程,处理不好,容易出现 #386 这里提到的问题,所以,改成了 EventTypeModuleData ,只进行解密,不进行解码。

未来我想办法解决吧,这个PR我先关掉了,感谢贡献。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯,好。期待大佬😉

return event
}

Expand Down
Loading