修复tls输出乱码问题 #419
Closed
修复tls输出乱码问题 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfc4n
reviewed
Nov 16, 2023
| @@ -174,7 +174,7 @@ func (se *SSLDataEvent) String() string { | |||
|
|
|||
| func (se *SSLDataEvent) Clone() IEventStruct { | |||
| event := new(SSLDataEvent) | |||
| event.eventType = EventTypeModuleData //EventTypeEventProcessor | |||
| event.eventType = EventTypeEventProcessor //EventTypeModuleData //EventTypeEventProcessor | |||
There was a problem hiding this comment.
从你提的issue #415 看到，好像是已经正常打印reponse了。我需要验证一下bug是否存在。
There was a problem hiding this comment.
嗯嗯，好，这个我在测试后发现改了这个type后就能输出明文。你看下如果原来的是没问题的，那么应该是我的理解存在错误。哈哈
There was a problem hiding this comment.
你理解的应该也没问题。
这里比较复杂，EventTypeEventProcessor 确实会对 gzip之类已编码的包进行二次解码，有很多需要组包的过程，处理不好，容易出现 #386 这里提到的问题，所以，改成了 EventTypeModuleData ，只进行解密，不进行解码。
未来我想办法解决吧，这个PR我先关掉了，感谢贡献。
cfc4n
reviewed
Nov 17, 2023
| @@ -174,7 +174,7 @@ func (se *SSLDataEvent) String() string { | |||
|
|
|||
| func (se *SSLDataEvent) Clone() IEventStruct { | |||
| event := new(SSLDataEvent) | |||
| event.eventType = EventTypeModuleData //EventTypeEventProcessor | |||
| event.eventType = EventTypeEventProcessor //EventTypeModuleData //EventTypeEventProcessor | |||
There was a problem hiding this comment.
你理解的应该也没问题。
这里比较复杂，EventTypeEventProcessor 确实会对 gzip之类已编码的包进行二次解码，有很多需要组包的过程，处理不好，容易出现 #386 这里提到的问题，所以，改成了 EventTypeModuleData ，只进行解密，不进行解码。
未来我想办法解决吧，这个PR我先关掉了，感谢贡献。
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重新更新了一下pr的文件