Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Replace empty ${EXCLUDE} variable with EXCLUDE_FROM_ALL #1660

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

enetheru
Copy link
Contributor

This was a mistake left over from the modernise PR

Left over from when I had a default target of template_debug, but it still wanted to build even if it was not depended on.
the targets should be excluded so that they dont all build all the time.

@enetheru enetheru marked this pull request as ready for review November 30, 2024 05:36
@enetheru enetheru requested a review from a team as a code owner November 30, 2024 05:36
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek dsnopek added bug This has been identified as a bug cmake labels Dec 2, 2024
@dsnopek dsnopek added this to the 4.x milestone Dec 2, 2024
This was a mistake left over from the modernise PR
@dsnopek dsnopek merged commit 163189f into godotengine:master Dec 6, 2024
11 checks passed
@enetheru enetheru deleted the exclude_typo branch December 6, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug cmake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants