Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gdextension_interface.h. Add metadata to GetTypeInfo of char16_t and char32_t. #1654

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Ivorforce
Copy link
Contributor

@Ivorforce Ivorforce commented Nov 26, 2024

Not sure if there is a standard workflow for updating, but I figured I'd go ahead and make a PR. Let me know if this is unusual or something is missing. I'm excited to get started on the variant internal accessors, so I'm making this PR first as an unopinionated update.

Let me note that i have no idea what GetTypeInfo is used for and if I'm applying the new enum cases correctly. I just went by surrounding code for context.

@Ivorforce Ivorforce requested a review from a team as a code owner November 26, 2024 20:46
@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Nov 28, 2024
@dsnopek dsnopek added this to the 4.x milestone Nov 28, 2024
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek dsnopek merged commit b378d8c into godotengine:master Nov 28, 2024
11 checks passed
@Ivorforce Ivorforce deleted the gdextension-interface-update branch November 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants