CMake: fix break for build prior to modernisation PR #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enetheru
changed the title
So that builds that relied on the alias already wont break.
enetheru
force-pushed
the
fix-backward-break
branch
from
fd70bb8 to
597055d
Compare
enetheru
added a commit
to enetheru/godot-cpp
that referenced
this pull request
Nov 28, 2024
Modernise existing cmake options Merge pull request godotengine#1647 from enetheru/fix#1459 CMake: Align MSVC runtime (MD[d], MT) options to engine Merge pull request godotengine#1649 from enetheru/fix-backward-break CMake: fix break for build prior to modernisation PR
enetheru
pushed a commit
to enetheru/godot-cpp
that referenced
this pull request
Dec 6, 2024
CMake: fix break for build prior to modernisation PR
enetheru
added a commit
to enetheru/godot-cpp
that referenced
this pull request
Dec 30, 2024
Modernise existing cmake options Merge pull request godotengine#1647 from enetheru/fix#1459 CMake: Align MSVC runtime (MD[d], MT) options to engine Merge pull request godotengine#1649 from enetheru/fix-backward-break CMake: fix break for build prior to modernisation PR CMake: Fix selection of MSVC Runtime compile flags My last attempt at solving this was not correct. I have left lots of comments in the source detailing the issue as it will effect consumers. Replace empty EXCLUDE variable with EXCLUDE_FROM_ALL This was a mistake left over from the modernise PR CMake: Handle GODOT_DEV_BUILD flag correctly .dev is added to output artifacts Warn users for specifying dev_build and Release build config Update documentation with deviations to SCons Update debug_symbols handling, its rolled into build config Cleanup helper variables and comments CMake: Enable using clang-cl on windows detect clang with MSVC frontend using CMAKE_CXX_COMPILER_FRONTEND_VARIANT Alleviate CMake target name clashes, visibility, and grouping. Simplify <platform>_generate cmake function signature, as TARGET_ALIAS and TARGET_NAME are still in scope and do not need to be passed. Add USE_FOLDERS, and FOLDER properties to group targets in VS and XCode Guard test target with GODOT_ENABLE_TESTING Tidy Small Issues remove RPATH_USE_ORIGIN from static libs add INTERFACE_POSITION_INDEPENDENT_CODE ON reset GODOT_ARCH property to SYSTEM_ARCH for macos because universal add MACOSX_RPATH to test target remove redundant properties from test target remove redundant and PUBLIC cxx_std_17 compile feature Privatise compiler options. CMake: Support using build_profile.json Python: - Redirect stdout for get_file_list to prevent stdout pollution CMake: - add GODOT_BUILD_PROFILE cache option - Split file list generation into its own function - add status and debug messages Python Snippets in CMake: - re-format for better readability Build Profile: - Add missing VisualInstance3D class to build_profile.json Add CMake support for XML documentation Implement generate_doc_source for cmake Implement generate_doc_source for cmake CMake: add lto options add a fake target to expose results of generator expressions move location of genex debug target so that it picks up the target details properly and allows us to generate for each type. first attempt Simplify Code Generation Variables - use generator expressions - use math for bits - simplify if statements Simplify SYSTEM_NAME generator expression. previous version created a list, which is semicolon delimited and then string REPLACED the semicolon to create a single string. New version uses string APPEND to create the string the first time. Update Target Properties - Using rpath for a static library is irrelevant, needs to be seet in consumers. - Add INTERFACE_POSITION_INDEPENDENT_CODE to propogate flag to consumers. Update macos - Add TODO for missing options - Fix formatting - Set GODOT_ARCH in case of arch being 'universal' - Simplify the test project when SYSTEM_NAME is Darwin Refactor common_compiler_flags.cmake - remove incorrectly propagated target_compile_features - remove GNU_ prefix on generic compiler version genex's - remove line breaks for simple genex's - make most flags private - comments Update Comments - Add TODO items for missing options - Add missing toolchain managed options commented out - Homogenise Headings and block comments replace ad-hock name construction with new GODOT_SUFFIX - This replicates how SCons does it. - Modify test project to use GODOT_SUFFIX - Add GODOT_SUFFIX to libgodot-cpp properties set web shared lib suffix to bring web builds into line with SCons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing tutorials and discussing with users, I thought of a way to mitigate breaking changes to cmake solution.
By re-adding the godot::cpp target alias as a template_debug lib it will solve a great deal of pain from users migrating.