Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typed_dictionary compile-time regression #1628

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix typed_dictionary compile-time regression #1628

merged 1 commit into from
Jan 21, 2025
+203 −201

Conversation

IvanInventor
Copy link

Fixes #1610

@IvanInventor IvanInventor requested a review from a team as a code owner October 21, 2024 01:25
@dsnopek dsnopek added the bug This has been identified as a bug label Jan 21, 2025
@dsnopek dsnopek added this to the 4.x milestone Jan 21, 2025
dsnopek
dsnopek approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me :-)

Before this PR:

real    2m8.664s
user    55m9.839s
sys     5m47.040s

After this PR:

real    0m39.244s
user    14m12.255s
sys     2m7.768s

@dsnopek dsnopek merged commit 13cd2d9 into godotengine:master Jan 21, 2025
12 checks passed
@dsnopek dsnopek mentioned this pull request Jan 21, 2025
Open
@NetroScript NetroScript mentioned this pull request Jan 21, 2025
Open
@dsnopek dsnopek mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

Compile time regression(?)
2 participants
@IvanInventor @dsnopek