Don't print an error when decoding a null Ref<T> #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
Ivorforce
approved these changes
Oct 16, 2024
|
Discussed at the GDExtension meeting and folks thought it looked good. |
|
Is anything stopping this from being merged? |
Nope, I just lost track of it :-) |
|
Cherry-picked for 4.2 in PR #1694 |
|
Cherry-picked for 4.3 in PR #1695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1615
It's not an error to receive a null pointer for a
Ref<T>- that's just how null reference values are encoded - so we shouldn't print an error message. This switches away fromERR_FAIL_NULL_V()to just a normalifstatement.