Add 3 unit tests for packed arrays #1606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... odd that the tests succeed here, because the following code definitely crashes my client: PackedByteArray x;
x.append(2);
PackedByteArray b = PackedByteArray((PackedByteArray&) a);That's on 1cce4d1. |
This should make all symbols that are not marked otherwise have hidden visibility. There still may be exposed symbols if marked with respective attributes.
changed cache type for api file and api dir to FILEPATH and PATH respectively. Minor whitespace. docstring parity
Required since Godot 4.3, which is also the first Godot version with wide WASM gdnative support (previous versions were Chrome-only, and very brittle).
and also the default cmake build directory when building in clion cmake-build-*
…_packed and test_append_to_packed).
Ivorforce
force-pushed
the
test-packed-manipulation
branch
from
d5e7d7c to
909ea89
Compare
|
Eh... Something went wrong. I'll just make another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rather a bug report than a pull request (though the unit tests don't hurt if they stay).
The unit tests (should) currently have the following status:
[PackedInt32Array([1]), PackedInt32Array([2])]I don't know much about godot-cpp and hope this is enough repro for someone to conjure a fix.