Correct element type for TypedArray<>
#1547
Open
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
raulsntos
commented
Aug 13, 2024
raulsntos
commented
- Part of Add metadata to TypedArray and validate at runtime godot#95492.
raulsntos
added
enhancement
raulsntos
commented
Aug 13, 2024
Comment on lines
-2711
to
-2714
| def correct_typed_array(type_name): | ||
| if type_name.startswith("typedarray::"): | ||
| return type_name.replace("typedarray::", "TypedArray<") + ">" | ||
| return type_name |
raulsntos
force-pushed
the
typedarray-metadata
branch
from
9a91fb1
to
9fd0a12
Compare
|
Thanks! I've only skimmed the changes, but at a glance this seems good :-) However, I think we should have the discussion I mentioned on the Godot PR before moving forward with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.