Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return code for render_handler #789

Merged
merged 4 commits into from
Feb 12, 2024
Merged

fix return code for render_handler #789

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d05178f
fix return code for render_handler
Thorsieger Jul 19, 2023
a23ef54
Merge branch 'main' into main
msaf1980 Aug 17, 2023
18e1af4
Merge branch 'main' into main
Civil Feb 12, 2024
1267c2f
Merge branch 'main' into main
Civil Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/carbonapi/http/render_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,8 @@ func renderHandler(w http.ResponseWriter, r *http.Request) {
// Obtain error code from the errors
// In case we have only "Not Found" errors, result should be 404
// Otherwise it should be 500
returnCode, errMsgs := helper.MergeHttpErrorMap(errors)
var errMsgs []string
returnCode, errMsgs = helper.MergeHttpErrorMap(errors)
logger.Debug("error response or no response", zap.Strings("error", errMsgs))
// Allow override status code for 404-not-found replies.
if returnCode == 404 {
Expand Down
Loading