Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return code for render_handler #789

Merged
merged 4 commits into from
Feb 12, 2024
Merged

fix return code for render_handler #789

merged 4 commits into from
Feb 12, 2024

Conversation

Thorsieger
Copy link
Contributor

@Thorsieger Thorsieger commented Jul 19, 2023

Hello,

carbonapi do not response correct code 404 when no metric is found from gocarbon/carbonserver when requesting for a render

This should fix the issue :

returnCode is reasigned in an other scope, so any modification won't have effect ouside the if

@msaf1980
Copy link
Collaborator

msaf1980 commented Aug 2, 2023

Hello,

carbonapi do not response correct code 404 when no metric is found from gocarbon/carbonserver when requesting for a render

This should fix the issue :

returnCode is reasigned in an other scope, so any modification won't have effect ouside the if

@Civil May be extend e2e tests for check status code ? Some of them are cheched, but this case not.

@Civil Civil enabled auto-merge February 12, 2024 21:16
@Civil Civil added this pull request to the merge queue Feb 12, 2024
Merged via the queue into go-graphite:main with commit e49e3b1 Feb 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants