Basic time types #1
Conversation
|
I think functions to create a timestamp from milliseconds and microseconds would be nice too! Millisecond (and microsecond to a lesser degree) int values will be common when interacting with external sources! |
|
Could you give some examples of those millisecond and microsecond Unix time sources @jrstrunk 🙏 |
|
Consuming external APIs is mainly what I was thinking of. This was the first to come to mind, but it is a little overkill with nanosecond timestamps: https://polygon.io/docs/stocks/get_v2_last_nbbo__stocksticker. I have seen it many times in proprietary APIs that I don't have access to anymore. Here is another one that gives the timestamp as a fractional second: https://platform.openai.com/docs/api-reference/audio/verbose-json-object. Again not exactly needing milliseconds or microseconds but they do exist! |
|
My hunch is that the existing from-nanoseconds will be enough given that nano and milli and micro are rather rare, so asking people to convert is OK. |
|
Could that run into the max unsafe integer on javascript though? |
|
That's fine with me! Anecdotally I seem to think millisecond timestamps are more common than second timestamps, but time and user feedback will tell, no need to worry about it too much now :) and it's not like the conversion is hard haha |
| export function system_time() { | ||
| const now = Date.now(); | ||
| const milliseconds = now % 1_000; | ||
| const nanoseconds = milliseconds * 1000_000; |
There was a problem hiding this comment.
Why isn't this stopping at nanoseconds lik the Erlang equivalent?
There was a problem hiding this comment.
Sorry, not sure what stopping at nanoseconds means.
If you're asking why it doesn't have nanosecond precision it's because JS doesn't have an API for system time with nanosecond precision
| let day_of_year = | ||
| day_of_era | ||
| - { 365 * year_of_era + { year_of_era / 4 } - { year_of_era / 100 } } | ||
| let mp = { 5 * day_of_year + 2 } / 153 |
There was a problem hiding this comment.
I honestly cannot remember. Might be that I got it from the reference and wasn't sure what it meant there either
Discussion: gleam-lang/gleam#4095
How does this design look?
Are there any other functions that we would want to have initially?
If we are happy with the overall design I could merge this and we could make PRs for the functions and documentation.