Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise function and lazy vs eager normalization #2

Closed
jrstrunk opened this issue Dec 23, 2024 · 4 comments
Closed

Normalise function and lazy vs eager normalization #2

jrstrunk opened this issue Dec 23, 2024 · 4 comments

Comments

@jrstrunk
Copy link

jrstrunk commented Dec 23, 2024

What are your plans for the normalise function in #1? By including it in the public interface, it seems there is an intention for lazily computed normalization after adds and subtracts. Is this correct? I understand the use case for this, but personally think we should consider eager normalization for a couple of reasons. I want to make sure of the intention before I type things out though.

@jrstrunk
Copy link
Author

I see the normalise function has been made private, this is less of a worry now!

@lpil
Copy link
Member

lpil commented Dec 23, 2024

Yes, following initial discussion on discord

@jrstrunk
Copy link
Author

I see I should probably join the discord haha

@lpil
Copy link
Member

lpil commented Dec 23, 2024

It's a lovely place! They're a fun bunch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants