Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent search entry #964

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Persistent search entry #964

wants to merge 1 commit into from

Conversation

sladkkr
Copy link

@sladkkr sladkkr commented Mar 29, 2023

Resolves issue #952

Changes:

  1. Search action is split into two distinct behaviors now:
  • toggle_search: Works as before hiding/showing search bar but only when search button was clicked.
  • focus_search: Toggles search bar visibility only when search entry has focus, if not then grabs focus back. Controlled only by shortcut.
  1. Hiding search bar does not erase it's content.

This is my first commit so I'm sorry if I did any obvious mistakes :)

@nekohayo
Copy link
Member

The big refactoring has finally landed! Please rebase this to the latest master.

@nekohayo nekohayo marked this pull request as draft February 26, 2024 18:15
@nekohayo nekohayo linked an issue Feb 26, 2024 that may be closed by this pull request
Ctrl+F keyboard shortcut should allow refocusing the searchentry widget and select its contents, rather than toggling it off and clearing the search #952
Open
@nekohayo nekohayo mentioned this pull request Feb 26, 2024
Closed
@nekohayo nekohayo added the bug label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@sladkkr @nekohayo