Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change search widget toggle behavior #979

Closed
wants to merge 1 commit into from
Closed

Change search widget toggle behavior #979

wants to merge 1 commit into from

Conversation

hanzala-sohrab
Copy link
Contributor

This PR is related to the issue #952.

Changes made in this PR:

  • Pressing Ctrl F will enable search widget.
  • Pressing Ctrl F again will not toggle off the search widget. Instead, the search widget will be refocused.
  • The search widget can be toggled off by pressing Escape key.

@hanzala-sohrab
Copy link
Contributor Author

@diegogangl Can you verify these changes?

@nekohayo nekohayo linked an issue Feb 26, 2024 that may be closed by this pull request
Ctrl+F keyboard shortcut should allow refocusing the searchentry widget and select its contents, rather than toggling it off and clearing the search #952
Open
@nekohayo
Copy link
Member

This needs to be rebased to the latest master. Apologies for the inconvenience.

At the same time, it is a duplicate of @sladkkr's #964, so you two might want to coordinate on this.

@nekohayo nekohayo marked this pull request as draft February 26, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
2 participants
@hanzala-sohrab @nekohayo