Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match actual version instead of regex in build CI job #3396

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Match actual version instead of regex in build CI job #3396

merged 2 commits into from
Sep 20, 2024

Conversation

lioman
Copy link
Contributor

@lioman lioman commented Sep 19, 2024

This is an alternative approach to #3395

  • get version from package
  • files need to start with pelican-

fixes #3393

Pull Request Checklist

Resolves: #issue-number-here

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@lioman
use a strict versioning in tests
9624397 
- get version from package
- files need to start with `pelican-`
@lioman lioman mentioned this pull request Sep 19, 2024
Closed
@justinmayer justinmayer changed the title use a strict versioning in tests Match actual version instead of regex in build CI job Sep 20, 2024
justinmayer
justinmayer approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for these fixes, @lioman. Much appreciated! 🥇

@justinmayer justinmayer merged commit 84db21c into getpelican:main Sep 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build test failures in GitHub CI workflow
2 participants
@lioman @justinmayer