Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build test failures in GitHub CI workflow #3393

Closed
justinmayer opened this issue Sep 16, 2024 · 3 comments · Fixed by #3396
Closed

Build test failures in GitHub CI workflow #3393

justinmayer opened this issue Sep 16, 2024 · 3 comments · Fixed by #3396
Labels

Comments

@justinmayer
Copy link
Member

It seems that GitHub CI suddenly started reporting that the build workflow job is failing:

➡️ https://github.com/getpelican/pelican/actions/runs/10884761305/job/30200770169

Only moments before, this job passed without problems. The only subsequent change was me pushing a RELEASE.md file in order to publish a new Pelican release.

@lioman: As the author of this CI job, could you take a look and shed some light on what might be happening here?

@lioman
Copy link
Contributor

lioman commented Sep 16, 2024

Will have a look

lioman added a commit to lioman/pelican that referenced this issue Sep 19, 2024
the regex, searching for the builded files was not stable to changes for two digit versions.

fixes: Build test failures in GitHub CI workflow getpelican#3393
@lioman
Copy link
Contributor

lioman commented Sep 19, 2024

@justinmayer made a quick fix. Perhaps one could solve that differently by pulling the version from pyproject.toml. To unblock the build I thought the quicker version is the best approach now.

@lioman
Copy link
Contributor

lioman commented Sep 19, 2024

And I made that alternative approach here: #3396

So both should fix those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants