Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View buttons: i18n + query support, component name from key #6901

Merged
merged 5 commits into from
Jan 14, 2025
Merged

View buttons: i18n + query support, component name from key #6901

merged 5 commits into from
Jan 14, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • Panel\Ui\Button: i18n support for text and title props
  • Panel\Ui\Buttons\ViewButtons and Panel\Ui\Buttons\ViewButton have new optional $model property
  • Kirby query support in Panel\Ui\Buttons\ViewButton for link, dialog, drawer, icon, text, theme props
  • Deriving the Vue component name from key:
buttons:
  - preview
  retour:
    text: Retour

This first looks up k-retour-view-button and falls back to k-view-button.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass
    • I think code coverage is given

For review team

@distantnative distantnative added this to the 5.0.0-beta.2 milestone Jan 11, 2025
@distantnative distantnative self-assigned this Jan 11, 2025
@distantnative distantnative force-pushed the v5/enhancement/view-buttons-query branch from 0a5a9b6 to fcd1d75 Compare January 11, 2025 18:59
@distantnative distantnative mentioned this pull request Jan 11, 2025
Closed
@distantnative distantnative linked an issue Jan 11, 2025 that may be closed by this pull request
[v5] View buttons with link should accept Query language similiar to page preview #6861
Closed
@distantnative distantnative changed the title View buttons: i18n + query support View buttons: i18n + query support, component name from key Jan 11, 2025
@distantnative distantnative force-pushed the v5/enhancement/view-buttons-query branch from 52b05f0 to 0db0596 Compare January 11, 2025 20:25
@distantnative distantnative mentioned this pull request Jan 12, 2025
Merged
@distantnative distantnative marked this pull request as ready for review January 12, 2025 11:24
@distantnative distantnative requested a review from a team January 12, 2025 11:24
bastianallgeier
bastianallgeier approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice additions!

@bastianallgeier bastianallgeier merged commit b330a0b into v5/develop Jan 14, 2025
11 of 12 checks passed
@bastianallgeier bastianallgeier deleted the v5/enhancement/view-buttons-query branch January 14, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
5.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

[v5] View buttons with link should accept Query language similiar to page preview
2 participants
@distantnative @bastianallgeier