[v5] View buttons with link should accept Query language similiar to page preview

[tobimori]

Description

This doesn't work - yet Query language works in options.preview.

buttons:
  preview:
    icon: youtube
    text: socialstar.youtube.video
    theme: red
    link: "https://youtu.be/{{ page.uuid.id }}"

Same for the text, so it works with translations.

Your setup

Kirby Version v5-beta.1

[medienbaecker]

I've noticed the view buttons do not accept a translation array either, is this the same issue?

buttons:
  email:
    text:
      de: Kontakt
      en: Contact
    icon: email
    link: mailto:[email protected]
    theme: info

This throws Kirby\Panel\Ui\Buttons\ViewButton::__construct(): Argument #16 ($text) must be of type ?string, array given.

Also, looking at the other stuff in my blueprint I'm wondering why this is text instead of label. I personally find it confusing/inconsistent.

[distantnative]

@medienbaecker it correlates to the text prop of k-button https://lab.getkirby.com/public/lab/docs/k-button

[distantnative]

@tobimori @medienbaecker I have a first draft at #6901 - do you think query/i18n support is needed for more props than listed currently?

[medienbaecker]

Is there a reason for limiting the props with translation/query support? I could imagine having a theme (positive, negative, ...) or icon (warning, check mark, ...) depending on a query would be very useful. Any prop probably 😅

[distantnative]

Performance (minimal) and just keeping the implementation clean and easy to maintain. Of course we could throw it at everything, but in the long run this isn't so helpful but rather might lead us into dead ends. That's why I think it does make sense to make intentional choices. E.g. I don't think there is much value in adding i18n support for theme or icon.