fix LogElementEvent not showing quicken bloom changes #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0l11
added
area: pkg
unleashurgeek
previously approved these changes
Dec 12, 2022
|
pls rebase this PR to resolve conflicts |
Since quicken bloom is programmed as a 0 delay task, we need to defer LogElementEvent to account for durability changes.
|
this fixes the quick bloom issue, but it breaks the element logs if two reactions happen on the same frame. see https://discord.com/channels/845087716541595668/983391844631212112/1191526441276411984, so I'm closing this in favor of a more holistic solution. i will include this problem as part of #390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since quicken bloom is programmed as a 0 delay task, we need to defer LogElementEvent to account for durability changes.