Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement "srp" #390

Open
3 tasks
srliao opened this issue Mar 11, 2022 · 0 comments
Open
3 tasks

implement "srp" #390

srliao opened this issue Mar 11, 2022 · 0 comments
Labels
area: pkg Related to core logic kind: design limitation Constraints of the existing architecture prevent this from being fixed

Comments

@srliao
Copy link
Contributor

srliao commented Mar 11, 2022

Relevant discussions here: https://discord.com/channels/763583452762734592/851428030094114847/951672464969183272

Changes required:

  • Sucrose burst absorption should do anemo damage first, then absorbed element
  • Kazuha burst absorption should do absorbed element damage first, then anemo
  • Aura attachment needs to happen AFTER damage calculation (resulting in not able to swirl absorbed element if target has no initial element)

The last point is actually consistent in general and not related to "srp"

Also... SRP not real xD only the last point matters and that appears to be a general quality of the reaction system and not specific to anemo/swirl/kazuha/sucrose etc...

Related Issues

@k0l11 k0l11 added the kind: bug Existing code is bugged label Aug 22, 2022
@k0l11 k0l11 pinned this issue Aug 30, 2022
@k0l11 k0l11 added area: pkg Related to core logic kind: design limitation Constraints of the existing architecture prevent this from being fixed and removed kind: bug Existing code is bugged labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: pkg Related to core logic kind: design limitation Constraints of the existing architecture prevent this from being fixed
Projects
None yet
Development

No branches or pull requests

2 participants