Add Ubuntu Jammy CI #864

scpeters · 2022-02-26T00:53:05Z

🦟 Bug fix

Part of gazebo-tooling/release-tools#566

Summary

Enable CI for Ubuntu 22.04 (Jammy)

Summary

Checklist

Signed all commits for DCO
Added tests
Updated documentation (as needed)
Updated migration guide (as needed)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <[email protected]>

scpeters · 2022-02-26T01:03:59Z

this needs libignition-common4-dev debs on jammy

codecov-commenter · 2022-02-26T01:40:31Z

Codecov Report

Merging #864 (3f1470a) into sdf12 (41c4920) will not change coverage.
The diff coverage is n/a.

❗ Current head 3f1470a differs from pull request most recent head d31c4dc. Consider uploading reports for the commit d31c4dc to get more accurate results

@@           Coverage Diff           @@
##            sdf12     gazebosim/sdformat#864   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          92       92           
  Lines       14221    14221           
=======================================
  Hits        12607    12607           
  Misses       1614     1614

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c4920...d31c4dc. Read the comment docs.

scpeters · 2022-03-04T18:22:10Z

pxr fails to build on Ubuntu 22.04 (jammy). Perhaps we should limit pxr testing to 20.04 (focal) for now?

cc @adlarkin @ahcorde

adlarkin · 2022-03-04T18:41:49Z

pxr fails to build on Ubuntu 22.04 (jammy). Perhaps we should limit pxr testing to 20.04 (focal) for now?

That sounds good to me 👍

Signed-off-by: Steve Peters <[email protected]>

scpeters · 2022-03-05T06:27:57Z

pxr fails to build on Ubuntu 22.04 (jammy). Perhaps we should limit pxr testing to 20.04 (focal) for now?

That sounds good to me 👍

done in 990d548

adlarkin · 2022-03-07T22:09:29Z

.github/ci/before_cmake.sh

@@ -7,12 +7,16 @@ BUILD_DIR=`pwd`
 cd /tmp

 # check that we can compile USD from sources (only Focal)
+return_code=0
+if [ "$(lsb_release -r -s)" != "20.04" ]; then
+  return_code=$(($return_code + 1))


since return_code is initialized to 0 above, can this be simplified to return_code=1?

I think it's easier to add new code and move things around in its current form.

adlarkin · 2022-03-07T22:52:19Z

pxr fails to build on Ubuntu 22.04 (jammy). Perhaps we should limit pxr testing to 20.04 (focal) for now?

Looking at this more closely, I believe it could be because you need to set certain environment variables to build pxr from source. Here are the environment variables set on Focal: https://github.com/ignitionrobotics/sdformat/blob/2a517d1bc563a831c68f9456897659ed054243e6/.github/workflows/ci.yml#L21-L23

@scpeters have you tried setting these environment variables on Jammy to see if it fixes the Jammy build?

scpeters · 2022-03-07T23:55:01Z

pxr fails to build on Ubuntu 22.04 (jammy). Perhaps we should limit pxr testing to 20.04 (focal) for now?

Looking at this more closely, I believe it could be because you need to set certain environment variables to build pxr from source. Here are the environment variables set on Focal:

https://github.com/ignitionrobotics/sdformat/blob/2a517d1bc563a831c68f9456897659ed054243e6/.github/workflows/ci.yml#L21-L23

@scpeters have you tried setting these environment variables on Jammy to see if it fixes the Jammy build?

I had not tried this, but I just did in bd0ab93

it is still failing:

2022-03-07T23:36:40.2577991Z [ 60%] Building CXX object pxr/base/work/CMakeFiles/work.dir/singularTask.cpp.o
2022-03-07T23:36:40.3566396Z In file included from /tmp/usd_binaries/USD-21.11/pxr/base/work/singularTask.cpp:24:
2022-03-07T23:36:40.3567151Z /tmp/usd_binaries/USD-21.11/pxr/base/work/singularTask.h: In lambda function:
2022-03-07T23:36:40.3568067Z /tmp/usd_binaries/USD-21.11/pxr/base/work/singularTask.h:111:21: error: 'size_t' was not declared in this scope; did you mean 'std::size_t'?
2022-03-07T23:36:40.3568421Z   111 |                     size_t old = count;
2022-03-07T23:36:40.3568644Z       |                     ^~~~~~
2022-03-07T23:36:40.3568845Z       |                     std::size_t
2022-03-07T23:36:40.3569371Z In file included from /usr/include/c++/11/bits/atomic_base.h:35,
2022-03-07T23:36:40.3569771Z                  from /usr/include/c++/11/atomic:41,
2022-03-07T23:36:40.3570258Z                  from /tmp/usd_binaries/USD-21.11/pxr/base/work/singularTask.h:31,
2022-03-07T23:36:40.3570810Z                  from /tmp/usd_binaries/USD-21.11/pxr/base/work/singularTask.cpp:24:
2022-03-07T23:36:40.3571440Z /usr/include/x86_64-linux-gnu/c++/11/bits/c++config.h:280:33: note: 'std::size_t' declared here
2022-03-07T23:36:40.3571824Z   280 |   typedef __SIZE_TYPE__         size_t;
2022-03-07T23:36:40.3572133Z       |                                 ^~~~~~
2022-03-07T23:36:40.3585857Z In file included from /tmp/usd_binaries/USD-21.11/pxr/base/work/singularTask.cpp:24:
2022-03-07T23:36:40.3586408Z /tmp/usd_binaries/USD-21.11/pxr/base/work/singularTask.h:113:56: error: 'old' was not declared in this scope
2022-03-07T23:36:40.3586778Z   113 |                         !count.compare_exchange_strong(old, 0));
2022-03-07T23:36:40.3587036Z       |                                                        ^~~
2022-03-07T23:36:40.3630030Z make[2]: *** [pxr/base/work/CMakeFiles/work.dir/build.make:177: pxr/base/work/CMakeFiles/work.dir/singularTask.cpp.o] Error 1

I noticed tbb deprecation warnings, so I'm wondering if it's related to PixarAnimationStudios/OpenUSD#1471

adlarkin · 2022-03-08T00:02:58Z

I had not tried this, but I just did in bd0ab93

it is still failing:

...

I noticed tbb deprecation warnings, so I'm wondering if it's related to PixarAnimationStudios/USD#1471

Okay, thanks for checking. Since there seem to be upstream issues on Jammy, I think we can stick with the approach of disabling pxr on Jammy for now. Would you mind leaving a comment after this line that references the upstream issues on Jammy? That way, we can re-visit this later on and try to re-enable pxr on Jammy whenever things are fixed upstream.

Signed-off-by: Steve Peters <[email protected]>

scpeters · 2022-03-08T06:37:40Z

I had not tried this, but I just did in bd0ab93
it is still failing:
...
I noticed tbb deprecation warnings, so I'm wondering if it's related to PixarAnimationStudios/USD#1471

Okay, thanks for checking. Since there seem to be upstream issues on Jammy, I think we can stick with the approach of disabling pxr on Jammy for now. Would you mind leaving a comment after this line that references the upstream issues on Jammy? That way, we can re-visit this later on and try to re-enable pxr on Jammy whenever things are fixed upstream.

I opened gazebosim/gz-usd#2 to track this and added a comment in ed62202

osrf-triage · 2022-04-13T21:30:44Z

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Add Ubuntu Jammy CI

247ce9c

Signed-off-by: Steve Peters <[email protected]>

scpeters requested a review from azeey as a code owner February 26, 2022 00:53

github-actions bot added the 🏯 fortress Ignition Fortress label Feb 26, 2022

scpeters mentioned this pull request Feb 26, 2022

Packaging and CI for Jammy gazebo-tooling/release-tools#566

Closed

scpeters added the needs upstream release Blocked by a release of an upstream library label Feb 28, 2022

scpeters added 2 commits March 4, 2022 22:27

GitHub CI: only build pxr on 20.04

990d548

Signed-off-by: Steve Peters <[email protected]>

Merge branch 'sdf12' into jammy_ci

2a517d1

adlarkin reviewed Mar 7, 2022

View reviewed changes

scpeters mentioned this pull request Jul 29, 2022

USD testing disabled in CI for 22.04 gazebosim/gz-usd#2

Closed

Add comment mentioning issue #869

ed62202

Signed-off-by: Steve Peters <[email protected]>

adlarkin approved these changes Mar 8, 2022

View reviewed changes

scpeters added 2 commits March 8, 2022 14:48

Merge branch 'sdf12' into jammy_ci

1a9666d

Merge branch 'sdf12' into jammy_ci

d31c4dc

scpeters merged commit 41d370d into gazebosim:sdf12 Mar 9, 2022

scpeters deleted the jammy_ci branch March 9, 2022 04:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Ubuntu Jammy CI #864

Add Ubuntu Jammy CI #864

scpeters commented Feb 26, 2022

scpeters commented Feb 26, 2022

codecov-commenter commented Feb 26, 2022 •

edited

Loading

scpeters commented Mar 4, 2022

adlarkin commented Mar 4, 2022

scpeters commented Mar 5, 2022

adlarkin Mar 7, 2022

scpeters Mar 7, 2022

adlarkin commented Mar 7, 2022

scpeters commented Mar 7, 2022

adlarkin commented Mar 8, 2022

scpeters commented Mar 8, 2022

osrf-triage commented Apr 13, 2022

Add Ubuntu Jammy CI #864

Add Ubuntu Jammy CI #864

Conversation

scpeters commented Feb 26, 2022

🦟 Bug fix

Summary

Summary

Checklist

scpeters commented Feb 26, 2022

codecov-commenter commented Feb 26, 2022 • edited Loading

Codecov Report

scpeters commented Mar 4, 2022

adlarkin commented Mar 4, 2022

scpeters commented Mar 5, 2022

adlarkin Mar 7, 2022

Choose a reason for hiding this comment

scpeters Mar 7, 2022

Choose a reason for hiding this comment

adlarkin commented Mar 7, 2022

scpeters commented Mar 7, 2022

adlarkin commented Mar 8, 2022

scpeters commented Mar 8, 2022

osrf-triage commented Apr 13, 2022

codecov-commenter commented Feb 26, 2022 •

edited

Loading