Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Environment Variable Migration : gz-transport #318

Merged
merged 2 commits into from
Jun 7, 2022
Merged

ign -> gz Environment Variable Migration : gz-transport #318

merged 2 commits into from
Jun 7, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from caguero as a code owner June 3, 2022 00:02
@methylDragon methylDragon mentioned this pull request Jun 3, 2022
Closed
49 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 3, 2022
@methylDragon methylDragon force-pushed the env_var_migration branch 9 times, most recently from 6e131fd to debaee5 Compare June 3, 2022 06:13
@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #318 (aeb86bd) into main (83ada1b) will increase coverage by 21.66%.
The diff coverage is 69.33%.

@@             Coverage Diff             @@
##             main     #318       +/-   ##
===========================================
+ Coverage   66.66%   88.32%   +21.66%     
===========================================
  Files           1       52       +51     
  Lines          24     4850     +4826     
===========================================
+ Hits           16     4284     +4268     
- Misses          8      566      +558
Impacted Files Coverage Δ
include/gz/transport/Discovery.hh 85.94% <60.00%> (ø)
src/NetUtils.cc 72.89% <66.66%> (ø)
src/NodeOptions.cc 96.22% <66.66%> (ø)
src/NodeShared.cc 78.02% <74.41%> (ø)
include/gz/transport/test_config.h
src/cmd/topic_main.cc 95.00% <0.00%> (ø)
log/src/Descriptor.hh 100.00% <0.00%> (ø)
log/src/cmd/LogCommandAPI.cc 62.50% <0.00%> (ø)
include/gz/transport/Uuid.hh 100.00% <0.00%> (ø)
src/NodeOptionsPrivate.hh 100.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ada1b...aeb86bd. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 3, 2022
@chapulina chapulina self-requested a review June 3, 2022 16:39
chapulina
chapulina reviewed Jun 3, 2022
View reviewed changes
include/gz/transport/Discovery.hh Outdated Show resolved Hide resolved
src/CIface_TEST.cc Outdated Show resolved Hide resolved
src/Discovery_TEST.cc Outdated Show resolved Hide resolved
src/NodeOptions_TEST.cc Outdated Show resolved Hide resolved
src/NodeShared.cc Show resolved Hide resolved
@methylDragon
Migrate environment variables
6cbfb0e 
Signed-off-by: methylDragon <[email protected]>
chapulina
chapulina approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@chapulina chapulina merged commit 1f207ca into main Jun 7, 2022
@chapulina chapulina deleted the env_var_migration branch June 7, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina