Apply suggestions from code review

Co-authored-by: Louise Poubel <[email protected]>
gazebosim · Jun 3, 2022 · a9b1345 · a9b1345
1 parent debaee5
commit a9b1345
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/include/gz/transport/Discovery.hh b/include/gz/transport/Discovery.hh
@@ -149,7 +149,7 @@ namespace gz
         // TODO(CH3): Deprecated. Remove on tock.
         else if (env("IGN_IP", gzIp) && !gzIp.empty())
         {
-          std::cout << "IGN_IP is deprecated and will be removed! "
+          std::cerr << "IGN_IP is deprecated and will be removed! "
                     << "Use GZ_IP instead!" << std::endl;
           this->hostInterfaces = {gzIp};
         }

diff --git a/src/CIface_TEST.cc b/src/CIface_TEST.cc
@@ -180,7 +180,7 @@ int main(int argc, char **argv)
   std::string partition = testing::getRandomNumber();
 
   // Set the partition name for this process.
-  setenv("", partition.c_str(), 1);
+  setenv("GZ_PARTITION", partition.c_str(), 1);
 
   // Enable verbose mode.
   // setenv("IGN_VERBOSE", "1", 1);

diff --git a/src/Discovery_TEST.cc b/src/Discovery_TEST.cc
@@ -529,7 +529,7 @@ TEST(DiscoveryTest, TestActivity)
 
 //////////////////////////////////////////////////
 /// \brief Check that a wrong GZ_IP value makes HostAddr() to return 127.0.0.1
-TEST(DiscoveryTest, WronggzIp)
+TEST(DiscoveryTest, WrongGzIp)
 {
   // Save the current value of GZ_IP environment variable.
   std::string gzIp;

diff --git a/src/NodeOptions_TEST.cc b/src/NodeOptions_TEST.cc
@@ -35,7 +35,7 @@ TEST(NodeOptionsTest, ignPartition)
   transport::NodeOptions opts;
   EXPECT_EQ(opts.Partition(), aPartition);
 
-  // A partition set by the user should overwrite .
+  // A partition set by the user should overwrite GZ_PARTITION.
   std::string userPartition = "userPartition";
   opts.SetPartition(userPartition);
   EXPECT_EQ(opts.Partition(), userPartition);