Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/logo component #55
Feature/logo component #55
Changes from all commits
a945298
8207967
5c4a759
60bd50d
92fd930
863eee8
7f9ccaf
0cec6ac
4a276e1
82751fa
79aa6f7
31b776d
d4d9933
5e00af7
d2f660f
e5e92d0
bb0bdec
a40a788
a48fda6
503d45b
1b52c80
d46ad36
e95726b
1fd8f59
41943b1
34aca85
703c232
6dd80ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goed idee, je zou hiervoor dus ook een extra className kunnen toevoegen die je dezelfde CSS geeft als de container-query die small is.
Dus iets als een property
small
voor de React component die de classframeless-logo--small
toevoegt. Die kun je dan hier gebruiken inargs: {small: true}
Alternatief is deze plugin toevoegen. https://storybook.js.org/docs/essentials/viewport
Beide kan wat mij betreft in een losse PR