Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logo component #55

Merged
merged 28 commits into from
Jun 14, 2024
Merged

Feature/logo component #55

merged 28 commits into from
Jun 14, 2024

Conversation

TessaViergever
Copy link
Collaborator

@TessaViergever TessaViergever commented May 21, 2024

In deze PR

Storybook

  • Storybook: React Logo story
  • Storybook: CSS logo story

Logo Component (CSS)

  • CSS logo component: index.scss
  • CSS logo component: readme.md

Logo Component (React)

  • React Logo component: LogoImage.tsx ( Frameless logo svg)
  • React Logo component: LogoText.tsx (Frameless logo letters)
  • React Logo component: LogoWrapper.tsx (Wrapt alle onderdelen van het Frameless logo)
  • React Logo component: index.tsx (voegt alle componenten samen)

Design Tokens

  • toevoeging logo component tokens aan figma.tokens.json

Overig

  • Fira Sans font toegevoegd (package.json + index.scss in /proprietary/font)

Wat nog moet gebeuren

  • aantal values in index.scss zijn nog geen tokens. Tokens toevoegen aan figma.tokens.json + deze values in scss vervangen voor de juiste tokens
  • uitzoeken of een aparte story nodig is voor iedere state van het logo (media/container queries) + toevoegen if needed
  • readme content aanvullen
  • frameless class (frameless-logo-image?) aanmaken in plaats van utrecht-logo?

Let op

Als deze PR gemerged is met main, en je wil je feature branch rebasen, vergeet dan niet pnpm install te doen (om de dependencies toe te voegen)

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 0:15am

packages/components-css/logo/index.scss Outdated Show resolved Hide resolved
proprietary/design-tokens/figma/figma.tokens.json Outdated Show resolved Hide resolved
packages/components-css/logo/index.scss Show resolved Hide resolved
@TessaViergever TessaViergever force-pushed the feature/logo-component branch from a988ea8 to bacffb5 Compare May 28, 2024 09:05
@TessaViergever TessaViergever force-pushed the feature/logo-component branch from 4ec1297 to 95cf279 Compare May 30, 2024 08:37
@TessaViergever TessaViergever linked an issue May 30, 2024 that may be closed by this pull request
4 tasks
@TessaViergever TessaViergever force-pushed the feature/logo-component branch from d4cb63d to 7a973f4 Compare June 4, 2024 09:09
@TessaViergever TessaViergever force-pushed the feature/logo-component branch from 7a973f4 to 5cbe75b Compare June 4, 2024 14:57
@TessaViergever TessaViergever force-pushed the feature/logo-component branch from 11eac6f to 4c2b607 Compare June 12, 2024 09:15
FramelessLogo will serve as the Logo wrapper. Apply styling from frameless-logo  to FramelessLogo
@Yolijn Yolijn force-pushed the feature/logo-component branch from 98659f1 to 6dd80ff Compare June 14, 2024 12:14
@Yolijn Yolijn merged commit b711726 into main Jun 14, 2024
8 checks passed
@Yolijn Yolijn deleted the feature/logo-component branch June 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo component
3 participants