Build passing on win and remove the C++20 feature #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `StatusLevel::ERROR` conflicts with `winsock2.h` included by `websocketpp\common\network.hpp`, we should undef the marco in `_WIN32` - designated initializers is C++20 feature, our [conanfile](https://github.com/foxglove/ws-protocol/blob/main/cpp/foxglove-websocket/conanfile.py#L18) just require C++17.
|
|
|
Note that this version of the server is pretty out of date, and needs to be replaced with the implementation at https://github.com/foxglove/ros-foxglove-bridge/tree/main/foxglove_bridge_base/include/foxglove_bridge once the dust has settled a bit. |
|
@jhurliman Thanks for reminder, these changes is indeed more reasonable. Can I sync these changes in another commit? |
|
No need, we will take care of it soon. Thanks! foxglove/ros-foxglove-bridge#89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
None
Description
StatusLevel::ERRORconflicts withwinsock2.hincluded bywebsocketpp\common\network.hpp, we should undef the marco in_WIN32#35