Switch foxglove client to using Requests.Session #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloff
approved these changes
Oct 1, 2024
|
This looks great, thanks for making this improvement. @james-rms can you think of any potential problems here? I couldn't see any. |
|
Seems good - @rg-gravis please sign the CLA and we can merge. |
sure - where is the CLA and how would you like me to sign? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Increase performance when making multiple requests by using HTTP keep-alive.
Docs
None
Description
Switch from using raw
requestsmethods to using arequests.Sessionobject, which automatically uses keep-alive connections and connection pooling (as per https://docs.python-requests.org/en/latest/user/advanced/). This makes the client faster when making multiple API calls in succession, because it doesn't need to re-negotiate a TCP connection for each call. The session object can also hold the headers and use them for every request.Tested with unit tests and
examples/downloading_data.py