Switch foxglove client to using Requests.Session #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Increase performance when making multiple requests by using HTTP keep-alive.
Docs
None
Description
Switch from using raw
requests
methods to using arequests.Session
object, which automatically uses keep-alive connections and connection pooling (as per https://docs.python-requests.org/en/latest/user/advanced/). This makes the client faster when making multiple API calls in succession, because it doesn't need to re-negotiate a TCP connection for each call. The session object can also hold the headers and use them for every request.Tested with unit tests and
examples/downloading_data.py