Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundle): remove rebuild because it causes slow performance on big… #528

Merged
merged 3 commits into from
Mar 7, 2024
Merged

fix(bundle): remove rebuild because it causes slow performance on big… #528

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3b929d
fix(bundle): remove rebuild because it causes slow performance on big…
BorjaMacedo Feb 22, 2024
2536414
feat(bundle): add skipRebuild option
BorjaMacedo Mar 5, 2024
ee7fef1
docs: add skipRebuild option
BorjaMacedo Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,13 @@ export async function bundle(this: EsbuildServerlessPlugin): Promise<void> {
type WithContext = typeof pkg & { context?: ContextFn };
const context = await (pkg as WithContext).context?.(options);

let result = await context?.rebuild();

if (!result) {
let result;
if (!buildOptions.skipRebuild) {
result = await context?.rebuild();
if (!result) {
result = await pkg.build(options);
}
} else {
result = await pkg.build(options);
}

Expand Down
1 change: 1 addition & 0 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export interface Configuration extends EsbuildOptions {
outputFileExtension: '.js' | '.cjs' | '.mjs';
nodeExternals?: NodeExternalsOptions;
skipBuild?: boolean;
skipRebuild?: boolean;
skipBuildExcludeFns: string[];
stripEntryResolveExtensions?: boolean;
disposeContext?: boolean;
Expand Down
Loading