-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bundle): remove rebuild because it causes slow performance on big… #528
fix(bundle): remove rebuild because it causes slow performance on big… #528
Conversation
+1 This is also blocking our pipeline. Would be amazing to get this into this amazing project!! |
Hi @BorjaMacedo thanks for the PR... https://github.com/floydspace/serverless-esbuild/pull/487/files I feel like better we need to introduce a new config option Is it what you can implement in this PR? |
I have implemented it and it seems to work perfectly. If you need me to do something else I can do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @BorjaMacedo , looks good, could you please also add the new property in readme options table with a short description what it does, and I will merge it.
@floydspace Done my friend! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BorjaMacedo awesome thank you, merging it
🎉 This PR is included in version 1.52.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
When the project is large, rebuild causes memory problems and prevents deployment in github actions and other environments.