Adding MacOS support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8398f7f.
|
After 52 commits worth of attempts, I'm giving up on getting OpenMP working on MacOS ARM for now. The problem appears to be some sort of incompatibility with OpenMP in the finufft wheels and OpenMP in nifty-ls. Part of the challenge is that the finufft wheels are currently cross-compiled from x86 to arm; maybe it will be easier to get working if/when they're natively compiled. Similarly, if we decided to vendor finufft instead of specifying it as a dependency, I bet we could get it working. Since OpenMP in finufft itself is still working as best as I can tell, the loss of not having OpenMP for the compiled extensions is small. |
… cpp helpers. Also avoid omp_set_num_threads() in library code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on building wheels for MacOS. The compiled extensions now build with
brew install libomp, but segfault during the tests.