Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sklearn test #240

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Fix sklearn test #240

merged 8 commits into from
Oct 4, 2024

Conversation

BalzaniEdoardo
Copy link
Collaborator

Fix some warnings in tests:

  • basis in conv acausal mode should have odd window size (we were setting even ws in tests sometimes)
  • jax needs to start multiprocessing in spawn, not forking.
  • shut off conversion error from jax to numpy array for the tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.24%. Comparing base (57ed379) to head (8343bcd).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #240   +/-   ##
============================================
  Coverage        97.24%   97.24%           
============================================
  Files               20       20           
  Lines             1815     1815           
============================================
  Hits              1765     1765           
  Misses              50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalzaniEdoardo BalzaniEdoardo merged commit e739138 into development Oct 4, 2024
12 checks passed
@BalzaniEdoardo BalzaniEdoardo deleted the fix_sklearn_test branch October 4, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants