Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adress issues with Transformers. When creating a pipeline, the number of basis should be equal to the number of dimensions for the feature.
If the number of columns for the feature is very high, it become tedious to add basis by hand. I added multiplication by integers for the class Basis.
There was also an issue where the class AdditiveBasis was trying to get the attributes
basis1
andbasis2
but they were only available as_basis1
and_basis2
. As a quick hack, i added two properties for AdditiveBasis that return basis 1 and basis 2.Extra: I also added the method
__len__
for Basis where it returns basis.n_basis_funcs. It's more convenient.