Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype check in simple Python interface #559

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

janden
Copy link
Collaborator

@janden janden commented Sep 11, 2024

Fixes #556.

This is a bugfix PR and should also be applied to 2.3.X.

@janden janden marked this pull request as ready for review September 11, 2024 20:04
Copy link
Collaborator

@ahbarnett ahbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I couldn't figure out how to use GitHub to start new v2.3.1 branch off v2.3.0 tag. (We already have things on master that shoudlnt' go into 2.3.x). Could you merge it into to master and such a branch? Thanks!

@ahbarnett ahbarnett merged commit e77225d into flatironinstitute:master Sep 11, 2024
167 checks passed
janden added a commit that referenced this pull request Sep 12, 2024
@janden
Copy link
Collaborator Author

janden commented Sep 12, 2024

Could you merge it into to master and such a branch? Thanks!

Created one here: https://github.com/flatironinstitute/finufft/tree/v2.3.X

Once we feel ready to release 2.3.1, we bump the version on that branch, tag it, and do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy dtypes from h5py not supported
2 participants