Solve issues with Python wheel building #546
Conversation
This commit does a few things: * Make cmake output a verbose makefile that tells us what commands are actually run. * Move some of the CIBW config settings for Windows into pyproject.toml. * Force wheels to be built with `-march=x86_64` to enhance compatibility (this seems to be an issue in particular running wheels on macOS with x86_64 compatibility mode on ARM chips). This excludes the macOS arm64 wheels, of course.
python/finufft/pyproject.toml
Outdated
| [[tool.cibuildwheel.overrides]] | ||
| select = "*arm64*" | ||
| # Don't enforce x84_64 when building on arm64. | ||
| config-settings = {"cmake.define.FINUFFT_ARCH_FLAGS" = "", "cmake.define.CMAKE_VERBOSE_MAKEFILE" = "ON"} |
There was a problem hiding this comment.
here we can still use march=native no? AFAIK from M1 to M3 they all support NEON only.
There was a problem hiding this comment.
I'd like to see this tested on those machines before enabling it. Maybe for 2.4?
There was a problem hiding this comment.
Okay, I compiled locally on my machine (apple-m1) with:
cmake ../ -DFINUFFT_ARCH_FLAGS=-mcpu=apple-m3 -DFINUFFT_USE_OPENMP=OFF -DFINUFFT_BUILD_TESTS=ON -DCMAKE_C_COMPILER=gcc-14 -DCMAKE_CXX_COMPILER=g++-14
and it passes the tests.
There was a problem hiding this comment.
Ok will add that, then.
There was a problem hiding this comment.
Does this address a fix for 2.3.0, ie should it come in now and go in the release?
There was a problem hiding this comment.
Yes. The macOS x86_64 wheels were still crashing under Rosetta 2 (emulation mode for ARM chips), so we had to fix some things.
Should be supported by all M* CPUs.
|
since this is a fix to 2.3.0, I'm bringing in. |
This PR does a few things:
-march=x86_64to enhance compatibility (this seems to be an issue in particular running wheels on macOS with x86_64 compatibility mode on ARM chips). This excludes the macOS arm64 wheels, of course.