Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude fortran/finufftfort.cpp by default #533

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Exclude fortran/finufftfort.cpp by default #533

merged 1 commit into from
Aug 27, 2024

Conversation

janden
Copy link
Collaborator

@janden janden commented Aug 20, 2024

This should only be compiled if FINUFFT_BUILD_FORTRAN is set to ON.

@janden
cmake: exclude fortran/finufftfort.cpp by default
04f1dcb 
This should only be compiled if `FINUFFT_BUILD_FORTRAN` is set to `ON`.
@janden janden marked this pull request as ready for review August 21, 2024 05:33
@janden janden requested a review from ahbarnett August 21, 2024 05:33
DiamonDinoia
DiamonDinoia approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@DiamonDinoia DiamonDinoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. CI tests passes.

@janden janden merged commit 0e9f569 into flatironinstitute:master Aug 27, 2024
167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiamonDinoia DiamonDinoia DiamonDinoia approved these changes

@ahbarnett ahbarnett Awaiting requested review from ahbarnett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janden @DiamonDinoia