[cmake] Cleanup redundant targets for annotate_fnt tool

flatironinstitute · Feb 9, 2024 · d8f57d8 · d8f57d8
1 parent cab0031
commit d8f57d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/share/cmake/Modules/clang_detection.cmake b/share/cmake/Modules/clang_detection.cmake
@@ -42,17 +42,15 @@ target_compile_options(clang_plugin
     -Wall
     -Wextra
     -Wpedantic
-    #-Wno-shadow
     -Wno-sign-compare
     -Wno-gcc-compat
     -Wno-unused-parameter
 )
-target_include_directories(clang_plugin SYSTEM INTERFACE ${CLANG_INCLUDE_DIR}  ${LLVM_INCLUDE_DIR})
+target_include_directories(clang_plugin SYSTEM INTERFACE ${CLANG_INCLUDE_DIR} ${LLVM_INCLUDE_DIR})
 
 # Allow undefined symbols in shared objects on Darwin (this is the default behaviour on Linux)
 target_link_libraries(clang_plugin INTERFACE "$<$<PLATFORM_ID:Darwin>:-undefined dynamic_lookup>")
 
 if (NOT LLVM_ENABLE_RTTI)
  target_compile_options(clang_plugin INTERFACE -fno-rtti)
 endif()
-
diff --git a/src/tools/annotate_fnt/CMakeLists.txt b/src/tools/annotate_fnt/CMakeLists.txt
@@ -1,10 +1,7 @@
 set(SRC_FILES ast_consumer.cpp matchers.cpp worker.cpp main.cpp)
 add_executable(annotate_fnt ${SRC_FILES} )
 
-target_link_libraries(annotate_fnt clang_plugin clu fmt::fmt )
-
-#target_link_libraries(clang_plugin INTERFACE  clangAST clangBasic clangDriver clangFrontend clangRewriteFrontend clangSerialization clangStaticAnalyzerFrontend clangTooling)
-target_link_libraries(annotate_fnt clangAST clangBasic clangDriver clangFrontend clangRewriteFrontend clangSerialization clangStaticAnalyzerFrontend clangTooling clang-cpp LLVMSupport)
+target_link_libraries(annotate_fnt clang_plugin clu fmt::fmt clangTooling)
 
 target_include_directories(annotate_fnt PRIVATE ${CMAKE_SOURCE_DIR}/c++ ${CMAKE_SOURCE_DIR}/src ${CMAKE_CURRENT_SOURCE_DIR})
 set_property(TARGET annotate_fnt PROPERTY POSITION_INDEPENDENT_CODE ON)