Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging cleanup #1378

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Logging cleanup #1378

merged 6 commits into from
Jul 25, 2024

Conversation

pgunn
Copy link
Member

@pgunn pgunn commented Jul 24, 2024

This implements #1376 and addresses #1374

It moves almost all use of logging to use a named logger rather than the base logger. This allows code that calls caiman to have different log levels than caiman does, giving the user more control over logging.

I included some minor cleanups of things I saw along the way (like f-string conversions and import cleanups), and updated the docs on the logger (which were incorrect even before this diff; they suggested a logger format that's not valid)

As I write this:

  1. I need to modify the jupyter notebooks too
  2. Need to see if this passes CI
  3. Will need to look at the diff a little more to make sure I didn't miss adding the code to reach the named logger I added to functions/methods

I'll push another revision to this to deal with the first, at least, and anything I need to change for the second and third

@pgunn
Copy link
Member Author

pgunn commented Jul 24, 2024

Second and third concerns are taken care of. I still need to loop back and adjust the jupyter notebooks. Will do that either later tonight or tomorrow.

@pgunn pgunn merged commit e8abf3b into dev Jul 25, 2024
3 checks passed
@pgunn pgunn deleted the dev-logging_cleanup branch July 25, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant