Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added dismissable layer and upgraded radix packages #1595

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • Allows users to safely use the escape key in the playground

What was the motivation & context behind this PR?

  • Playground drawer was executing keydown presses first, which was not correct behavior

How has this PR been tested?

Screen.Recording.2024-10-03.at.5.53.08.PM.mov

Copy link
Contributor

@abvthecity abvthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the large diff on pnpm-lock.yaml is fishy.

i think since you pnpm up + pnpm install a bunch of dependencies got upgraded.

i'd do heavy testing if we want to be doing this. otherwise lets

  1. git checkout the pnpm-lock file from main
  2. pnpm install again (reusing main's lockfile)

Copy link

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9 seconds
commit  313708a

Copy link

PR Preview

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 162.69 KB (🟢 -94.59 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/404 332 B 163.02 KB 46.58%

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/dynamic/[host]/[[...slug]] 52.68 KB 215.38 KB 61.54% (🟢 -6.99%)
/static/[host]/[[...slug]] 52.68 KB 215.37 KB 61.54% (🟢 -6.99%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

Playwright test results

passed  81 passed

Details

stats  81 tests across 3 suites
duration  1 minute, 43 seconds
commit  313708a

@RohinBhargava RohinBhargava merged commit cd82e3e into main Oct 10, 2024
21 of 22 checks passed
@RohinBhargava RohinBhargava deleted the rohin/playground-escaping-dismissable-layer branch October 10, 2024 15:03
RohinBhargava added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants