Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: added dismissable layer and upgraded radix packages" #1655

Merged

Conversation

RohinBhargava
Copy link
Member

Reverts #1595

Copy link

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9 seconds
commit  3695a24

Copy link

PR Preview

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 162.55 KB (🟢 -94.73 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/404 332 B 162.87 KB 46.53%
/dynamic/[domain]/[[...slug]] 52.7 KB 215.25 KB 61.50%
/static/[domain]/[[...slug]] 52.7 KB 215.25 KB 61.50%

Copy link

Playwright test results

passed  81 passed

Details

stats  81 tests across 3 suites
duration  1 minute, 21 seconds
commit  3695a24

@@ -21,7 +21,6 @@

&[data-scrollbars="vertical"] > div {
max-width: 100%;
width: 100%;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abvthecity this is the change I had to make for the dropdown. I believe we can do the same for the scroll area

@RohinBhargava RohinBhargava merged commit bfa4860 into main Oct 11, 2024
22 checks passed
@RohinBhargava RohinBhargava deleted the revert-1595-rohin/playground-escaping-dismissable-layer branch October 11, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants