Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umbrella: Adding support for new field types in plugins #990

Open
7 of 52 tasks
therealbobo opened this issue Mar 20, 2023 · 21 comments
Open
7 of 52 tasks

Umbrella: Adding support for new field types in plugins #990

therealbobo opened this issue Mar 20, 2023 · 21 comments
Assignees
@therealbobo
Labels
kind/feature New feature or request
Milestone
TBD

Comments

@therealbobo
Copy link
Contributor

therealbobo commented Mar 20, 2023 •
edited by jasondellaluce
Loading

Motivation

Currently, the plugin API only supports uint64 and charbuf field types. However, could be a good idea to add support for additional types to align with the libsinsp library.

Feature

The following types need to be added:

  • none
  • int8
  • int16
  • int32
  • int64
  • uint8
  • uint16
  • uint32
  • uint64
  • bytebuf
  • errno
  • sockaddr
  • socktuple
  • fd
  • pid
  • fdlist
  • fspath
  • syscallid
  • sigtype
  • reltime
  • abstime
  • port
  • l4proto
  • sockfamily
  • bool
  • ipv4addr
  • dyn
  • flags8
  • flags16
  • flags32
  • uid
  • gid
  • double
  • sigset
  • charbufarray
  • pt_charbuf_pair_array
  • ipv4addr
  • ipv4net
  • ipv6addr
  • ipv6net
  • ipaddr
  • ipnet
  • mode
  • fsrelpath
  • enumflags8
  • enumflags16
  • enumflags32
  • max

Probably not all these types are useful.
Additionally adding all these types, maybe, could result in performance penalties.

Tasks

  • Add support for new filtercheck types.
  • Test the new filtercheck types.
  • Ensure compatibility with driver/ppm_events_public.h.
  • Update documentation to reflect the changes.

Additional context

These types should be compatible with the types declared in the driver/ppm_events_public.h in the libs repository.

This issue will be used only for tracking.
@therealbobo therealbobo added the kind/feature New feature or request label Mar 20, 2023
@Andreagit97
Copy link
Member

I will add milestone 0.11.0 just to track it :) Feel free to change it
/milestone 0.11.0

@poiana poiana added this to the 0.11.0 milestone Mar 20, 2023
This was referenced Mar 22, 2023
Merged
Merged
@LucaGuerra
Copy link
Contributor

Hey @therealbobo , I don't think we need all of them :) Also because perhaps the types that sinsp supports are a bit too many :)

I think it makes sense to start from a minimal list and add more when necessary

@therealbobo
Copy link
Contributor Author

therealbobo commented Mar 27, 2023 •
edited
Loading

You are right! I already started to work on it and implemented some basic types! 😄

@therealbobo
Copy link
Contributor Author

/assign

@FedeDP
Copy link
Contributor

FedeDP commented Apr 27, 2023

/milestone 0.12.0

@poiana poiana modified the milestones: 0.11.0, 0.12.0 Apr 27, 2023
@leogr
Copy link
Member

leogr commented May 3, 2023

/milestone 0.13.0 assuming this is a long-term task

@poiana
Copy link
Contributor

poiana commented May 3, 2023

@leogr: The provided milestone is not valid for this repository. Milestones in this repository: [0.11.0, 0.12.0, 0.13.0, 5.0.0+driver, next-driver]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 0.13.0 assuming this is a long-term task

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr leogr modified the milestones: 0.12.0, 0.13.0 May 3, 2023
@Rohith-Raju Rohith-Raju mentioned this issue May 31, 2023
Merged
1 task
@Andreagit97 Andreagit97 modified the milestones: 0.13.0, libs-backlog Jun 7, 2023
@poiana
Copy link
Contributor

poiana commented Sep 5, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Oct 5, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Nov 5, 2023

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this as completed Nov 5, 2023
@poiana
Copy link
Contributor

poiana commented Nov 5, 2023

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Andreagit97 Andreagit97 reopened this Nov 6, 2023
@jasondellaluce
Copy link
Contributor

/remove-lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Feb 4, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented May 6, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Aug 5, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Nov 4, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Nov 4, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@therealbobo therealbobo

Labels
kind/feature New feature or request
Projects
None yet
Milestone
TBD
Development

No branches or pull requests
7 participants
@leogr @FedeDP @jasondellaluce @LucaGuerra @therealbobo @poiana @Andreagit97