-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Support for new field types in plugins #71
Conversation
Welcome @therealbobo! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉 |
Hi @therealbobo. Thanks for your PR. I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a8bb7a7
to
024a2d9
Compare
/hold |
I was thinking that could be a good idea to add some helpers: that way the final user will use directly, for example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @therealbobo
Could you rebase this, pls?
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
9022da1
to
8b701b8
Compare
Signed-off-by: Roberto Scolaro <[email protected]>
8b701b8
to
ba6ca3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 1c4eca83174d1450d30a9a45a77b08ca2119155d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugin-sdk
/area tests
What this PR does / why we need it:
This adds support for the main types described in the issue below.
Which issue(s) this PR fixes:
Umbrella: Adding support for new field types in plugins
Special notes for your reviewer:
This is still a WIP: it will need a lot of improvements for performance and clean up for sure!
Does this PR introduce a user-facing change?: