Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Support for new field types in plugins #71

Merged
merged 6 commits into from
May 16, 2023

Conversation

therealbobo
Copy link
Contributor

@therealbobo therealbobo commented Mar 22, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

This adds support for the main types described in the issue below.

Which issue(s) this PR fixes:

Umbrella: Adding support for new field types in plugins

Special notes for your reviewer:

This is still a WIP: it will need a lot of improvements for performance and clean up for sure!

Does this PR introduce a user-facing change?:

action required: update plugins to use new sdk version
action required: add the new plugin types in libs

@poiana
Copy link

poiana commented Mar 22, 2023

Welcome @therealbobo! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

@poiana
Copy link

poiana commented Mar 22, 2023

Hi @therealbobo. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/L label Mar 22, 2023
@therealbobo therealbobo changed the title [WIP]: Support for new field types in plugins new: Support for new field types in plugins Apr 14, 2023
@therealbobo
Copy link
Contributor Author

/hold

@therealbobo
Copy link
Contributor Author

I was thinking that could be a good idea to add some helpers: that way the final user will use directly, for example, net.IP instead of populating the buffer manually. WDYT? @jasondellaluce
/unhold

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @therealbobo

Could you rebase this, pls?

@therealbobo therealbobo force-pushed the feat/new-api-types branch 3 times, most recently from 9022da1 to 8b701b8 Compare May 9, 2023 12:55
Signed-off-by: Roberto Scolaro <[email protected]>
@therealbobo therealbobo force-pushed the feat/new-api-types branch from 8b701b8 to ba6ca3f Compare May 16, 2023 08:28
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented May 16, 2023

LGTM label has been added.

Git tree hash: 1c4eca83174d1450d30a9a45a77b08ca2119155d

@poiana
Copy link

poiana commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 55e9d80 into falcosecurity:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants