feat: support for new field types in plugins #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
do-not-merge/work-in-progress
kind/feature
|
Also, I think the |
|
@therealbobo @jasondellaluce it looks to me that all comments have been addressed. Is there anything left to get it out of WIP? |
|
Yes, @LucaGuerra! |
therealbobo
changed the title
|
@therealbobo just needs a rebase I think :) |
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
therealbobo
force-pushed
the
feat/new-plugin-api-types
branch
from
ea065f4 to
418689d
Compare
|
LGTM label has been added. Git tree hash: 278c665e1a48f921f511f22322a71704108781aa
|
FedeDP
approved these changes
Apr 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This adds support for the main types described in the issue below.
Which issue(s) this PR fixes:
#990
Special notes for your reviewer:
This is still a WIP: it will need a lot of improvements for performance and clean up for sure!
Does this PR introduce a user-facing change?: