Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of surrogate_specs with surrogate_spec #2959

Closed
wants to merge 1 commit into from

Commits on Oct 25, 2024

  1. Replace usage of surrogate_specs with surrogate_spec (facebook#2959)

    Summary:
    
    This is a clean up diff that replaces deprecated `surrogate_specs` with newly introduced `surrogate_spec` across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate related `Keys` are no longer needed, so those are also removed.
    
    Also adds a `_extract_surrogate_spec_from_surrogate_specs` helper to convert single element `surrogate_specs` in `model_kwargs` to `surrogate_spec` during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection.
    
    Reviewed By: sdaulton
    
    Differential Revision: D64877651
    saitcakmak authored and facebook-github-bot committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    62d302a View commit details
    Browse the repository at this point in the history