Replace usage of surrogate_specs with surrogate_spec #2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64877651 |
facebook-github-bot
added
CLA Signed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2959 +/- ##
==========================================
- Coverage 95.65% 95.64% -0.01%
==========================================
Files 486 486
Lines 48827 48835 +8
==========================================
+ Hits 46704 46708 +4
- Misses 2123 2127 +4 ☔ View full report in Codecov by Sentry. |
saitcakmak
force-pushed
the
export-D64877651
branch
from
f2b79e3
to
077618b
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 24, 2024
Summary: This is a clean up diff that replaces deprecated `surrogate_specs` with newly introduced `surrogate_spec` across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate related `Keys` are no longer needed, so those are also removed. Also adds a `_extract_surrogate_spec_from_surrogate_specs` helper to convert single element `surrogate_specs` in `model_kwargs` to `surrogate_spec` during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection. Differential Revision: D64877651
|
This pull request was exported from Phabricator. Differential Revision: D64877651 |
saitcakmak
force-pushed
the
export-D64877651
branch
from
077618b
to
3f2e1b3
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Oct 25, 2024
Summary: This is a clean up diff that replaces deprecated `surrogate_specs` with newly introduced `surrogate_spec` across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate related `Keys` are no longer needed, so those are also removed. Also adds a `_extract_surrogate_spec_from_surrogate_specs` helper to convert single element `surrogate_specs` in `model_kwargs` to `surrogate_spec` during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection. Reviewed By: sdaulton Differential Revision: D64877651
|
This pull request was exported from Phabricator. Differential Revision: D64877651 |
Summary: This is a clean up diff that replaces deprecated `surrogate_specs` with newly introduced `surrogate_spec` across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate related `Keys` are no longer needed, so those are also removed. Also adds a `_extract_surrogate_spec_from_surrogate_specs` helper to convert single element `surrogate_specs` in `model_kwargs` to `surrogate_spec` during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection. Reviewed By: sdaulton Differential Revision: D64877651
saitcakmak
force-pushed
the
export-D64877651
branch
from
3f2e1b3
to
62d302a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64877651 |
|
This pull request has been merged in c3014fc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a clean up diff that replaces deprecated
surrogate_specswith newly introducedsurrogate_specacross fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate relatedKeysare no longer needed, so those are also removed.Also adds a
_extract_surrogate_spec_from_surrogate_specshelper to convert single elementsurrogate_specsinmodel_kwargstosurrogate_specduring de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection.Differential Revision: D64877651