-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usage of surrogate_specs with surrogate_spec #2959
Conversation
This pull request was exported from Phabricator. Differential Revision: D64877651 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2959 +/- ##
==========================================
- Coverage 95.65% 95.64% -0.01%
==========================================
Files 486 486
Lines 48827 48835 +8
==========================================
+ Hits 46704 46708 +4
- Misses 2123 2127 +4 ☔ View full report in Codecov by Sentry. |
f2b79e3
to
077618b
Compare
Summary: This is a clean up diff that replaces deprecated `surrogate_specs` with newly introduced `surrogate_spec` across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate related `Keys` are no longer needed, so those are also removed. Also adds a `_extract_surrogate_spec_from_surrogate_specs` helper to convert single element `surrogate_specs` in `model_kwargs` to `surrogate_spec` during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection. Differential Revision: D64877651
This pull request was exported from Phabricator. Differential Revision: D64877651 |
077618b
to
3f2e1b3
Compare
Summary: This is a clean up diff that replaces deprecated `surrogate_specs` with newly introduced `surrogate_spec` across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate related `Keys` are no longer needed, so those are also removed. Also adds a `_extract_surrogate_spec_from_surrogate_specs` helper to convert single element `surrogate_specs` in `model_kwargs` to `surrogate_spec` during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection. Reviewed By: sdaulton Differential Revision: D64877651
This pull request was exported from Phabricator. Differential Revision: D64877651 |
Summary: This is a clean up diff that replaces deprecated `surrogate_specs` with newly introduced `surrogate_spec` across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate related `Keys` are no longer needed, so those are also removed. Also adds a `_extract_surrogate_spec_from_surrogate_specs` helper to convert single element `surrogate_specs` in `model_kwargs` to `surrogate_spec` during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection. Reviewed By: sdaulton Differential Revision: D64877651
3f2e1b3
to
62d302a
Compare
This pull request was exported from Phabricator. Differential Revision: D64877651 |
This pull request has been merged in c3014fc. |
Summary:
This is a clean up diff that replaces deprecated
surrogate_specs
with newly introducedsurrogate_spec
across fbcode (except for places where it is needed for testing backwards compatibility). After this change, surrogate relatedKeys
are no longer needed, so those are also removed.Also adds a
_extract_surrogate_spec_from_surrogate_specs
helper to convert single elementsurrogate_specs
inmodel_kwargs
tosurrogate_spec
during de-serialization. This was a way to fix some of the internal BC tests while adding another layer of BC protection.Differential Revision: D64877651