Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm Analyzer: tweak top-scorers comment #2288

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

jiegillet
Copy link
Contributor

@ceddlyburge could you take a look?

You originally wrote

Maybe to something like this:
'aggregateScorers is most easily written using updateGoalCountForPlayer and List.foldl (list.foldr also works, but it a bit les ergonomic).'

But foldl and foldr have the same signature, so there is no change in ergonomy. There might be some efficiency difference, but it's not obvious and I don't want to get into that in an exercise about dictionaries.

@jiegillet
Copy link
Contributor Author

@exercism/reviewers an I get an approval please? 💛

@jiegillet jiegillet merged commit bea57bd into main Oct 31, 2023
1 check passed
@jiegillet jiegillet deleted the jie-top-scorers-foldr branch October 31, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track/elm Elm track type/analyzer-comments Analyzer comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants