Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of List.foldr in top-scorers #62

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

jiegillet
Copy link
Contributor

@jiegillet jiegillet commented Oct 28, 2023

Closes #56

I didn't change the analyzer comment

aggregateScorers is most easily written using List.foldl and updateGoalCountForPlayer.

because it's still true, but should I? If someone uses List.foldr but not updateGoalCountForPlayer, would they be confused and change both? It's not a huge deal I guess.

@jiegillet jiegillet requested a review from a team as a code owner October 28, 2023 06:31
Copy link
Contributor

@ceddlyburge ceddlyburge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it probably is worth updating the copy.

Maybe to something like this:
'aggregateScorers is most easily written using updateGoalCountForPlayer and List.foldl (list.foldr also works, but it a bit les ergonomic).'

@jiegillet
Copy link
Contributor Author

Opened a PR for the copy update: exercism/website-copy#2288

I don't think it's fundamentally blocking this PR though, so I'll merge it now.

@jiegillet jiegillet merged commit 4c391a0 into main Oct 31, 2023
6 checks passed
@jiegillet jiegillet deleted the jie-top-scorers-foldr branch October 31, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check rule at top scores
3 participants