Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further BCO isotope product #153

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

observingClouds
Copy link
Collaborator

@observingClouds observingClouds commented Nov 14, 2023

  • fix BCO PICARRO unsupported time dimension upstream
  • change datatype of flag variable in BCO precipitation isotope product or change access protocol

@observingClouds observingClouds marked this pull request as ready for review November 15, 2023 00:19
@observingClouds observingClouds changed the title Add further isotope product Add further BCO isotope product Nov 29, 2023
@observingClouds
Copy link
Collaborator Author

@leonie-villiger I encountered an issue with the PICARRO dataset. The time dimension has an unsupported unit leading to an error in the CI but also when opening the dataset with common tools like panoply as the time dimension cannot be interpreted. Could you change that and release a new version of the dataset?

netcdf EUREC4A_BCO_PICARRO_WVISOS_L1.nc {
  dimensions:
    time = 51838;
  variables:
    double time(time=51838);
      :units = "seconds since 19700101_00";

seconds since 1970-01-01 00:00:00 would work for example if the time is given in UTC. Please have a look at the time dimension information given in CF-Conventions which are widely supported.

@observingClouds
Copy link
Collaborator Author

@leonie-villiger I also encountered an issue with the rainwater isotope product. The variable flag has the type long (int64). This is generally fine but when accessing the file via OPeNDAP this causes an issue because the datatype is not supported. AERIS provides this access to your dataset via this protocol (see Download | Data access section at https://doi.org/10.25326/242) and we generally try to access these datasets the same way as it allows us to load the datasets lazily, i.e. do not need to download the entire dataset.

Looking at the dataset it seems the flag has only the values [0,1,2] so you could just use short (int16) instead. @d70-t has put together a nice overview about problematic data types at https://howto.eurec4a.eu/netcdf_datatypes.html

Could you look into this as well a release a version of the dataset with a different datatype? In this particular case, we might also use a different access protocol to circumvent this issue because the dataset is in total only 21KB 🤣 and downloading the entire dataset does not hurt.

@leonie-villiger
Copy link
Contributor

@observingClouds: working on both issues. I will let you know as soon as we succeeded releasing new versions of the datasets

description: BCO CRDS Continuous In-Situ Water Vapor Isotopic Composition
driver: opendap
args:
urlpath: https://observations.ipsl.fr/thredds/dodsC/EUREC4A/BARBADOS/BCO/PICARRO/EUREC4A_BCO_PICARRO_WVISOS_L1.nc
Copy link
Contributor

@leonie-villiger leonie-villiger Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
urlpath: https://observations.ipsl.fr/thredds/dodsC/EUREC4A/BARBADOS/BCO/PICARRO/EUREC4A_BCO_PICARRO_WVISOS_L1.nc
urlpath: https://observations.ipsl.fr/thredds/dodsC/EUREC4A/BARBADOS/BCO/vapour/EUREC4A_BCO_PICARRO_WVISOS_L3.nc

That is the official version (i.e., the one linked from https://doi.org/10.25326/245). But it still has the issue with the non-standard time unit. Working on it...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leonie-villiger, just wanted to check if you had a chance to look into this again 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A new version of the BCO precipitation isotope product with corrected datatype of flag variable has been uploaded and is now accessible via OPeNDAP.
  • Franziska will take care of the unsupported time dimension in the BCO PICARRO dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants