-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ATR isotope data #158
Add ATR isotope data #158
Conversation
ab9dc6d
to
378a247
Compare
- adapt flight segment syntax from HALO/P3 - adapt P3 isotope syntax - add additional subentries for quantity (water wapor) and instrument (CRDS)
378a247
to
39664b6
Compare
Hi @leonie-villiger,
|
Hi @leonie-villiger and @observingClouds , This would seem consistent from my point of view, the format mostly accommodates the HALO/P3 standards already (On first sight, I see that we call the segment kind rather "kinds" and allow several entries...). A small readme could be added to explain new types of segment kinds in the style of Then there are additional isotope meta data files (isotope-analyzer-CRDS.yaml). I understand that these should be kept independent of the flight segment files since they contain a lot of arguments that don't contain flight segment information. Maybe the How about opening a PR to the flight-phase-separation repo with the addition of the ATR metadata files to iterate on the details? |
@Smpljack thanks for your response! This is already very helpful.
Correct!
Ah, the
The (isotope-analyzer-CRDS.yaml) is currently only referencing the ATR metadata files. Because these ATR metadata files are (almost) flight segmentation files, they seem to be of much better use if they are handled like that, i.e. be accessible through the flight-segmentation "API" |
I added the additional flights in ATR/isotope-analyzer-CRDS.yaml. Had to add the flight number to the identifier, because we sometimes had two flights on one day ( Yes, it was a CRDS instrument on the ATR. All correct! @observingClouds and @Smpljack There are two types of metadata:
I assume it is rather number 2 which you want to include in the flight-phase-separation repository... Also, when adding ATR metadata files (flight segments) it would make sense to add the ATR tracks (part of the SAFIRE-CORE data) somewhere. An overview of all ATR dataset is provided in Bony et al. (2022). |
Alright, I think we can merge this for now and talk about the flight segmentation separately. |
The integration of ATR flight segments is discussed at eurec4a/flight-phase-separation#32 |
No description provided.